feat: switch from node-sass (deprecated) to sass #5159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlockhart
commented
Nov 18, 2024
| $include-pseudo-classes: false, | ||
| $line-height: normal, | ||
| $padding: 0.5rem 0.75rem, | ||
| $padding-focus: calc(0.5rem - 1px) calc(0.75rem - 1px) | ||
| ); | ||
| overflow: auto; |
There was a problem hiding this comment.
Having rules declared after an @include is also deprecated. Moving it up to the top has no effect on the CSS.
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
dbatiste
approved these changes
Nov 18, 2024
|
🎉 This PR is included in version 3.70.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches core's Sass compiler from
node-sasswhich is deprecated tosass. BSI is already usingsass.I updated the imports to the new
@usesyntax as the other format is also deprecated and will be going away shortly. The new syntax requires that every thing referenced from an import use a namespace that matches the filename.I've linked this with BSI and verified that the CSS output is identical.