feat: add common localization support and ability to specify input pattern validation failure text #5134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
bearfriend
approved these changes
Nov 5, 2024
dlockhart
changed the title
dlockhart
commented
Nov 21, 2024
|
|
||
| it('should localize "&"', () => { | ||
| const localized = elem.localizeCharacter('&'); | ||
| expect(localized).to.equal('ampersand'); |
There was a problem hiding this comment.
Mostly just a smoke test as I didn't want to repeat everything from @brightspace-ui/intl.
bearfriend
approved these changes
Nov 21, 2024
|
🎉 This PR is included in version 3.71.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds common localization support to
LocalizeMixinwhich is useful when listing characters when a text input's pattern validation fails.