Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Move static builds to d2l.dev bucket #3898

Merged
merged 3 commits into from
Aug 24, 2023
Merged

ci: Move static builds to d2l.dev bucket #3898

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a04d6b
ci: Move static builds to d2l.dev bucket
eKoopmans Aug 17, 2023
9cec0a5
Move to live.d2l.dev
eKoopmans Aug 24, 2023
a586f8d
Use github.repository variable
eKoopmans Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,14 +66,14 @@ jobs:
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
aws-session-token: ${{ secrets.AWS_SESSION_TOKEN }}
role-to-assume: arn:aws:iam::037018655140:role/brightspace-ui-core.d2l.dev-githubactions-access
role-to-assume: arn:aws:iam::022062736489:role/r+BrightspaceUI+core+repo
role-duration-seconds: 3600
aws-region: ca-central-1

- name: Publish
uses: BrightspaceUI/actions/publish-to-s3@main
with:
bucket-path: s3://brightspace-ui-core.d2l.dev/branches/pr-${{ github.event.number }}
bucket-path: s3://d2l.dev/live/prs/BrightspaceUI/core/pr-${{ github.event.number }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider making this a little more copy-pastable

Suggested change
bucket-path: s3://d2l.dev/live/prs/BrightspaceUI/core/pr-${{ github.event.number }}
bucket-path: s3://d2l.dev/live/prs/${{ github.repository }}/pr-${{ github.event.number }}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call Owen, I've updated the docs to use {{ github.repository }} too!

publish-directory: ./build/

- name: Notify
Expand All @@ -84,7 +84,7 @@ jobs:

We've deployed an automatic preview for this PR - you can see your changes here:

| URL | https://pr-${{ github.event.number }}-brightspace-ui-core.d2l.dev/ |
| URL | https://live.d2l.dev/prs/BrightspaceUI/core/pr-${{ github.event.number }}/ |
|---|---|

> **Note**
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,12 @@ jobs:
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
aws-session-token: ${{ secrets.AWS_SESSION_TOKEN }}
role-to-assume: arn:aws:iam::037018655140:role/brightspace-ui-core.d2l.dev-githubactions-access
role-to-assume: arn:aws:iam::022062736489:role/r+BrightspaceUI+core+repo
role-duration-seconds: 3600
aws-region: ca-central-1

- name: Publish
uses: BrightspaceUI/actions/publish-to-s3@main
with:
bucket-path: s3://brightspace-ui-core.d2l.dev/branches/main
bucket-path: s3://d2l.dev/live/BrightspaceUI/core
publish-directory: ./build/
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ Start a [@web/dev-server](https://modern-web.dev/docs/dev-server/overview/) that
npm start
```

D2L employees can also view the latest main-branch demos at https://brightspace-ui-core.d2l.dev/.
D2L employees can also view the latest main-branch demos at https://live.d2l.dev/BrightspaceUI/core/.

### Linting

Expand Down