[MI-3060]:Fixed review comments of PR #376 on gitlab plugin#38
Merged
Kshitij-Katiyar merged 4 commits intoMM-326from May 8, 2023
Merged
[MI-3060]:Fixed review comments of PR #376 on gitlab plugin#38Kshitij-Katiyar merged 4 commits intoMM-326from
Kshitij-Katiyar merged 4 commits intoMM-326from
Conversation
ayusht2810
approved these changes
May 5, 2023
manojmalik20
approved these changes
May 5, 2023
raghavaggarwal2308
pushed a commit
that referenced
this pull request
Mar 11, 2024
…tial issues, and disallow guests from creating subscriptions (mattermost#376) * [MI-3045]: Added checks for confidential issues at the time of making subscriptions (#37) * [MI-3045]:Added checks for confidential issues * [MI-3045]:Added unit test cases * [MI-3045]:Fixed self review comments * [MI-3045]:Fixed unit test cases * [MI-3045]:Fixed lint errors * [MI-3045]:Fixed review comments * [MI-3045]:Fixed context deadline error * [MI-3045]:Fixed review comments * [MI-3045]:Fixed statements * [MI-3060]:Fixed review comments of PR mattermost#376 on gitlab plugin (#38) * [MI-3060]:Fixed review comments of PR mattermost#376 on gitlab plugin * [MI-3060]:Fixed test cases * [MI-3060]:Updated the msg * [MI-3060]:Fixed the test cases * [MM-326]:fixed test cases * [MM-326]:Fixed CI error * [MM-326]:Fixed review comments * [MM-326]:Fixed review comments --------- Co-authored-by: ayusht2810 <ayush.thakur@brightscout.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mattermost#376