Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow default detection algorithm if one is not specified #329

Closed
Breakthrough opened this issue Jul 7, 2023 · 1 comment
Closed

Allow default detection algorithm if one is not specified #329

Breakthrough opened this issue Jul 7, 2023 · 1 comment
Milestone

Comments

@Breakthrough
Copy link
Owner

Breakthrough commented Jul 7, 2023

Problem/Use Case

A detector must be specified currently for scenedetect to perform any actions on the input. Ideally this should not be the case - a default detector should be chosen if one is omitted, and the user should be able to set it in the config file.

Solutions

Allow commands of the form:

scenedetect -i video.mp4 split-video

The default will be detect-adaptive, but the user should also have a config file option with the name of the detector to use, e.g. in the config file:

[global]
default-detector = detect-threshold

One particular issue I ran into when trying to fix this by handling this in the controller is that some erroneous commands still result in the input being processed, e.g.:

scenedetect -i video.mp4 load-scenes -i doesnotexist.csv

Scene detection proceeds due to the current design, and the error doesn't get printed until after detection was done and the video was split. The command should not run at all if any subcommand has an error when processing options, or an unrecognized subcommand is provided.

Breakthrough added a commit that referenced this issue Jul 8, 2023
Allow commands of the form `scenedetect -i video.mp4 split-video` for example.

Uses detect-adaptive as the current default.

TODO: Add a config option to control which detector to use.

Issue: #329
@Breakthrough Breakthrough added this to the v0.6.2 milestone Jul 8, 2023
@Breakthrough
Copy link
Owner Author

Usage examples have been greatly simplified in the upcoming version, and nearly all examples of commands can now be copied and pasted directly into a terminal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant