-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pvlib weather #42
Draft
mikofski
wants to merge
9
commits into
BreakingBytes:master
Choose a base branch
from
mikofski:pvlib_weather
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Pvlib weather #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add weather resource stub in api - add weather form with lat, lon, start year, end year, tmy bool - add weather step and header - add more description to solar position, define zenith, azimuth - link to pvlib.solarposiiton.get_solarposition - fix airmass is relative not absolute
- add new src links to [email protected], [email protected], and [email protected] replaces [email protected], [email protected], [email protected] - add vega-action for embedded links? - fix typos in weather, solar position - add style to #vis <div> element to set width: 100%; - remove calculations for vis_width and vis_height, replace with comment and link to vega-lite docs - change width to 'container' and set height to 400 - add tooltips to point marks - update vega-lite $schema to v5
- add sources like pvgis, psm3, etc to weather form - add file upload field for tmy2/3 - add weather-resource api endpoint to urls - add weather form to pvlib view - reorganize form contect into dictionary comprehension - TODO: script adds .form-control to all input fields b/c using Django forms, but need to remove from checkbox
- remove class form-control from checkbox and file inputs - move tmy checkbox and file upload to new row, resize cols - use forms.weatherform.tmy.if_for_label to get just the id for the label because bootstrap
- add tmy_ prefix to weather form inputs - update to esri leaflet 2.2.4 to resolve error and get proper attributions - add stub for weather api call on pvlib.html
- upgrade to pvlib-0.9.5 to use iotools - pvlib-0.9.5 requires scipy-1.7.3 and pandas-1.3.5 - get cleaned parameters and call get_psm3 - add tmy_freq for psm3 interval, nrel_api_key, & email to weather form - add freq for nrel interval to weather form in pvlib.html - add copy button to solar position
- update calls to pandas with date_range(start, end, ...) - add FIXME for shifting solpos timestamp to center of interval if needed - use NREL API KEY and email - hardcode PSM3 tmy timestamps for now, but leave TODO to add coerced year to form - change anchor for TOC to "tmy-weather" - ditto nrel api key and email to form - remove row-grid container for weather form submit button, unnecessary - leave placeholder for weather vis - ditto solarposition buttons - start hacking jquery together to call API weather endpoint - add click action to copy weather inputs to solpos
- use choices for year name - only pull single years - change end year to coerced year - remove feb29 from leap years - add time zone from metadata - catch http errors and show message - shift times to interval midpoints - allow both tmy and time-series
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
started but never finished 😞