Add else and elseif statement as forbidden (#95)

* Add else and elseif statement as forbidden

default-ecs.php

@@ -5,6 +5,7 @@
 use BrandEmbassyCodingStandard\Sniffs\Classes\TraitUsePositionSniff;
 use BrandEmbassyCodingStandard\Sniffs\Classes\TraitUseSpacingSniff;
 use BrandEmbassyCodingStandard\Sniffs\Commenting\FunctionCommentSniff;
+use BrandEmbassyCodingStandard\Sniffs\ForbiddenElseStatementSniff;
 use BrandEmbassyCodingStandard\Sniffs\NamingConvention\CamelCapsFunctionNameSniff;
 use BrandEmbassyCodingStandard\Sniffs\WhiteSpace\BlankLineBeforeReturnSniff;
 use BrandEmbassyCodingStandard\Sniffs\WhiteSpace\BlankLineBeforeThrowSniff;
@@ -948,6 +949,8 @@
         ],
     );
 
+    $ecsConfig->rule(ForbiddenElseStatementSniff::class);
+
     return [
         // Checked by BrandEmbassyCodingStandard.NamingConvention.CamelCapsFunctionName
         CamelCapsMethodNameSniff::class,

ecs.php

@@ -39,6 +39,7 @@
             __DIR__ . '/src/BrandEmbassyCodingStandard/Sniffs/WhiteSpace/BlankLineBeforeThrowSniff.php',
         ],
         __DIR__ . '/*/__fixtures__/*',
+        __DIR__ . '/*/__fixtures/*',
     ];
 
     $ecsConfig->skip(array_merge($defaultSkipList, $skipList));

phpstan.neon

@@ -14,4 +14,5 @@ parameters:
     excludePaths:
         - src/BrandEmbassyCodingStandard/Sniffs/TypeHints/TypeHintDeclarationSniff.php
         - src/BrandEmbassyCodingStandard/*/__fixtures__/*
+        - src/BrandEmbassyCodingStandard/*/__fixtures/*
 

src/BrandEmbassyCodingStandard/Sniffs/ForbiddenElseStatementSniff.php

@@ -0,0 +1,46 @@
+<?php declare(strict_types = 1);
+
+namespace BrandEmbassyCodingStandard\Sniffs;
+
+use PHP_CodeSniffer\Files\File;
+use PHP_CodeSniffer\Sniffs\Sniff;
+use function strtolower;
+use const T_ELSE;
+use const T_ELSEIF;
+
+/**
+ * @final
+ */
+class ForbiddenElseStatementSniff implements Sniff
+{
+    public const CODE_FORBIDDEN_ELSE_STATEMENT_SNIFF = 'ForbiddenElseStatement';
+
+
+    /**
+     * @return int[]|string[]
+     */
+    public function register(): array
+    {
+        return [
+            T_ELSE,
+            T_ELSEIF,
+        ];
+    }
+
+
+    /**
+     * @phpcsSuppress SlevomatCodingStandard.TypeHints.ParameterTypeHint.MissingNativeTypeHint
+     *
+     * @param int $stackPtr
+     */
+    public function process(File $phpcsFile, $stackPtr): void
+    {
+        $tokens = $phpcsFile->getTokens();
+
+        $statement = strtolower($tokens[$stackPtr]['content']);
+
+        $error = 'Use of ' . $statement . ' is forbidden. See: https://github.com/BrandEmbassy/developers-manifest/issues/365.';
+
+        $phpcsFile->addError($error, $stackPtr, self::CODE_FORBIDDEN_ELSE_STATEMENT_SNIFF);
+    }
+}

src/BrandEmbassyCodingStandard/Sniffs/ForbiddenElseStatementSniffTest.php

@@ -0,0 +1,33 @@
+<?php declare(strict_types = 1);
+
+namespace BrandEmbassyCodingStandard\Sniffs;
+
+use SlevomatCodingStandard\Sniffs\TestCase;
+
+/**
+ * @final
+ */
+class ForbiddenElseStatementSniffTest extends TestCase
+{
+    public function testErrorIsAdded(): void
+    {
+        $file = __DIR__ . '/__fixtures/codeWithElseStatement.php';
+        require_once $file;
+
+        $report = self::checkFile($file);
+
+        self::assertSniffError(
+            $report,
+            13,
+            'ForbiddenElseStatement',
+            'Use of elseif is forbidden.',
+        );
+
+        self::assertSniffError(
+            $report,
+            15,
+            'ForbiddenElseStatement',
+            'Use of else is forbidden.',
+        );
+    }
+}

src/BrandEmbassyCodingStandard/Sniffs/__fixtures/codeWithElseStatement.php

@@ -0,0 +1,19 @@
+<?php declare(strict_types = 1);
+
+namespace BrandEmbassyCodingStandard\Sniffs\__fixtures;
+
+use Mockery\MockInterface;
+
+class CreateMockFunctions
+{
+    private function withNoPhpDoc(): void
+    {
+        if (true) {
+            echo 'bar';
+        } elseif (true) {
+            echo 'lol';
+        } else {
+            echo 'foo';
+        }
+    }
+}