hellovai/bench

[hellovai]

• Adding benchmarks
• benchmarks compile

---

Important

Add criterion benchmarks to the jsonish library for performance testing of various data structures and parsing scenarios.

• Benchmarks:
  • Add criterion benchmarks for jsonish in benches/ directory.
  • Benchmarks include classes.rs, lists.rs, literals.rs, partials.rs, and unions.rs.
  • Each benchmark tests parsing performance for different data structures and scenarios.
• Dependencies:
  • Add criterion as a dev-dependency in Cargo.toml with html_reports feature.
• Helpers:
  • Add helpers module with common.rs and mod.rs for shared benchmark utilities.
• Misc:
  • Update Cargo.lock with new dependencies for benchmarks.

^{This description was created by for 42a08de. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 42a08de in 59 seconds

More details

• Looked at 1246 lines of code in 15 files
• Skipped 0 files when reviewing.
• Skipped posting 4 drafted comments based on config settings.

1. engine/baml-lib/jsonish/benches/classes.rs:10

• Draft comment:
  Consider using jsonish::helpers::render_output_format instead of Builder::new(target.clone()).build() for consistency with other benchmark files like unions.rs. This ensures that the OutputFormatContent is constructed in a consistent manner across all benchmarks.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The code in the benches directory is using Builder::new(target.clone()).build() to create an OutputFormatContent, but this is inconsistent with the unions.rs file where jsonish::helpers::render_output_format is used. This inconsistency might lead to different behaviors in benchmarks.

2. engine/baml-lib/jsonish/benches/lists.rs:10

• Draft comment:
  Consider using jsonish::helpers::render_output_format instead of Builder::new(target.clone()).build() for consistency with other benchmark files like unions.rs. This ensures that the OutputFormatContent is constructed in a consistent manner across all benchmarks.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The code in the benches directory is using Builder::new(target.clone()).build() to create an OutputFormatContent, but this is inconsistent with the unions.rs file where jsonish::helpers::render_output_format is used. This inconsistency might lead to different behaviors in benchmarks.

3. engine/baml-lib/jsonish/benches/literals.rs:10

• Draft comment:
  Consider using jsonish::helpers::render_output_format instead of Builder::new(target.clone()).build() for consistency with other benchmark files like unions.rs. This ensures that the OutputFormatContent is constructed in a consistent manner across all benchmarks.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The code in the benches directory is using Builder::new(target.clone()).build() to create an OutputFormatContent, but this is inconsistent with the unions.rs file where jsonish::helpers::render_output_format is used. This inconsistency might lead to different behaviors in benchmarks.

4. engine/baml-lib/jsonish/benches/partials.rs:46

• Draft comment:
  Consider using jsonish::helpers::render_output_format instead of Builder::new(target.clone()).build() for consistency with other benchmark files like unions.rs. This ensures that the OutputFormatContent is constructed in a consistent manner across all benchmarks.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The code in the benches directory is using Builder::new(target.clone()).build() to create an OutputFormatContent, but this is inconsistent with the unions.rs file where jsonish::helpers::render_output_format is used. This inconsistency might lead to different behaviors in benchmarks.

Workflow ID: wflow_Jd9922NQVRmsxpWH

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
baml	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 14, 2025 7:54pm