Nuke

[antoniosarosi]

• cargo clippy --fix && cargo fmt
• Fix clippy stuff manually if --fix doesn't.
• Delete jsonish old unused module.

---

Important

Refactor and clean up code across Ruby and TypeScript clients, improve error handling, logging, and test reporting.

• Code Cleanup:
  • Remove unused old module in jsonish.
  • Simplify logic in parse_ts_types.rs and ruby_to_json.rs.
• Error Handling:
  • Improve error messages and handling in parse_ts_types.rs and ruby_to_json.rs.
  • Enhance error conversion in runtime.rs.
• Type Handling:
  • Refactor TypeBuilder and FieldType in both Ruby and TypeScript clients.
  • Add Default implementations for TypeBuilder in type_builder.rs.
• Logging and Tracing:
  • Improve logging in runtime.rs and span.rs.
  • Enhance tracing capabilities in span.rs.
• Test Reporting:
  • Update test report HTML structure in test-report.html.

^{This description was created by for 0bcb002. It will automatically update as commits are pushed.}

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
baml	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 2, 2024 0:32am

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 0bcb002 in 5 minutes and 20 seconds

More details

• Looked at 13546 lines of code in 195 files
• Skipped 0 files when reviewing.
• Skipped posting 3 drafted comments based on config settings.

1. engine/baml-lib/llm-client/src/clients/openai.rs:259

• Draft comment:
  The use of clone() on self.properties is unnecessary since self.properties is already a reference. This can be optimized by removing the clone() call.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The use of clone() on self.properties is unnecessary since self.properties is already a reference. This can be optimized by removing the clone() call.

2. engine/baml-lib/llm-client/src/clients/openai.rs:276

• Draft comment:
  The use of clone() on self.properties is unnecessary since self.properties is already a reference. This can be optimized by removing the clone() call.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The use of clone() on self.properties is unnecessary since self.properties is already a reference. This can be optimized by removing the clone() call.

3. engine/baml-lib/llm-client/src/clients/openai.rs:286

• Draft comment:
  The use of clone() on self.properties is unnecessary since self.properties is already a reference. This can be optimized by removing the clone() call.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The use of clone() on self.properties is unnecessary since self.properties is already a reference. This can be optimized by removing the clone() call.

Workflow ID: wflow_dwGD8nmMB0kbi8ZA

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.