Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Vertex docs for different publishers #1191

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

antoniosarosi
Copy link
Contributor

@antoniosarosi antoniosarosi commented Nov 23, 2024

Add instructions for publishers such as Meta

Important

Adds documentation for using non-Google publishers with Vertex AI, including an example for Meta's Llama model.

  • Documentation:
    • Adds section for using non-Google publishers in vertex.mdx.
    • Provides example for configuring base_url for Meta's Llama model.

This description was created by Ellipsis for f15a8a6. It will automatically update as commits are pushed.

Copy link

vercel bot commented Nov 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
baml ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 23, 2024 11:31pm

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to f15a8a6 in 9 seconds

More details
  • Looked at 26 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. fern/03-reference/baml/clients/providers/vertex.mdx:284
  • Draft comment:
    Consider adding a model option in the example to specify which model from the other publisher is being used. This will make the example more complete and clear.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR adds a new section for using models from publishers other than Google, which is a useful addition. However, the example provided does not include a model specification, which might be necessary for clarity and completeness.

Workflow ID: wflow_ovbD0aTXjXxCxYQN


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@antoniosarosi antoniosarosi added this pull request to the merge queue Nov 24, 2024
Merged via the queue into canary with commit 66b2274 Nov 24, 2024
10 checks passed
@antoniosarosi antoniosarosi deleted the antonio/vertex-docs branch November 24, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant