only popup the vscode env var dialog once #1066
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 4e09b54 in 22 seconds
More details
- Looked at
65lines of code in2files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_TfkOxh1kcYM03uhN
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| <Dialog open={showSettings} onOpenChange={setShowSettings}> | ||
| <Dialog open={showSettings} onOpenChange={(open) => { | ||
| setShowSettings(open) | ||
| setHasClosedEnvVarsDialog(true) |
There was a problem hiding this comment.
The logic for setting hasClosedEnvVarsDialog is incorrect. It should be set to true only when the dialog is closed, not when it is opened. Consider updating the logic to:
| setHasClosedEnvVarsDialog(true) | |
| setHasClosedEnvVarsDialog(!open) |
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 2ac140b in 17 seconds
More details
- Looked at
35lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. typescript/playground-common/src/shared/SettingsDialog.tsx:250
- Draft comment:
Consider addinghasClosedEnvVarsDialogto the dependency array of theuseEffecthook to ensure the effect re-runs when it changes. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_ZqYOItH3JtUaXYpF
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Important
Ensure the VSCode environment variables dialog only appears once by tracking its closed state with
hasClosedEnvVarsDialogAtom.hasClosedEnvVarsDialogAtominEventListener.tsxto track if the environment variables dialog has been closed.ShowSettingsButtonandSettingsDialoginSettingsDialog.tsxto checkhasClosedEnvVarsDialogAtombefore showing the dialog.atomWithStorageforhasClosedEnvVarsDialogAtomto persist the closed state across sessions.SettingsDialog.tsx, the dialog only opens automatically ifhasClosedEnvVarsDialogAtomisfalse.This description was created by
for 2ac140b. It will automatically update as commits are pushed.