Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more test cases for unquoted strings in objects #1054

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

hellovai
Copy link
Contributor

@hellovai hellovai commented Oct 17, 2024

Important

Add test case for handling unquoted strings with spaces in JSON-like objects in test_class.rs.

  • Tests:
    • Add test_string_field_with_spaces in test_class.rs to handle unquoted strings with spaces in JSON-like objects.
    • Validates deserialization of strings with spaces and newline characters.

This description was created by Ellipsis for abeceb6. It will automatically update as commits are pushed.

Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
baml ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 9:45pm

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to abeceb6 in 10 seconds

More details
  • Looked at 32 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. engine/baml-lib/jsonish/src/tests/test_class.rs:1215
  • Draft comment:
    Unquoted strings in JSON are not valid. If this is intentional for testing a specific feature, consider adding a comment to clarify. Otherwise, wrap the strings in quotes.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_hcsPEYZ9h1ETzAzS


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@hellovai hellovai added this pull request to the merge queue Oct 21, 2024
Merged via the queue into canary with commit 2d1b700 Oct 21, 2024
10 checks passed
@hellovai hellovai deleted the parsing-test-case branch October 21, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant