Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add limit on connection pool to prevent stalling issues in pyo3 and other ffi boundaries #1027

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

hellovai
Copy link
Contributor

@hellovai hellovai commented Oct 11, 2024

Important

Set pool_max_idle_per_host(0) in create_tracing_client() to prevent connection pool stalling issues across FFI boundaries.

This description was created by Ellipsis for 4808a8f. It will automatically update as commits are pushed.

Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
baml ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 6:13pm

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 4808a8f in 13 seconds

More details
  • Looked at 29 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. engine/baml-runtime/src/request/mod.rs:28
  • Draft comment:
    The variable cb is declared but not used in the wasm32 configuration branch. Consider using cb or removing the declaration to avoid confusion.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_MfkB2rfSHt6uU1IT


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@hellovai hellovai added this pull request to the merge queue Oct 11, 2024
Merged via the queue into canary with commit eb90e62 Oct 11, 2024
9 of 10 checks passed
@hellovai hellovai deleted the connection_pool branch October 11, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant