Fix (?) i-term error rotation #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkleiner
reviewed
Apr 2, 2024
bkleiner
force-pushed
the
fix-rodrigues-rotation
branch
4 times, most recently
from
922e811 to
7abbcd4
Compare
bkleiner
force-pushed
the
fix-rodrigues-rotation
branch
from
7abbcd4 to
b21ec20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming that the "rotation error" part is due to the implementation of Rodrigues' rotation equation at small angles, this PR fixes the equivalent implementation.