-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert most Buffer usage to Uint8Array #2103
Conversation
I propose the primary objective (requirement) is to ensure music-metadata can depend on strtok3 and token-type, the "Goodbye Node.js Buffer" versions. To replace remaining (all) Buffer dependencies in music-metadata is a secondary objective, which can be address in following stage (different PR). The first objective, I think it is good to do before applying the changes in file-type (as health check as proposed here). The remaining Buffer dependencies in music-metadata should not delay your effort to work towards getting this into file-type. Only the secondary stage depends on the "Goodbye Node.js Buffer" version of file-type. |
I agree, we don't need to replace all the Buffer usage in the first pass. I think Once the shared dependencies are released it should be clear that |
09dd444
to
9df4cf8
Compare
Can you have a look to the remaining test cases, why these are failing? |
b4c8502
to
2a3744d
Compare
I managed to music-metadata pass all unit tests 💯✅, combining all outstanding PR's: |
Appveyor is failing because I added a fix for it in #2105 |
c1ee297
to
ccae86e
Compare
@Borewit This needs a new release of |
3d2917b
to
9f7b8d1
Compare
All dependencies have been updated, this should be good to go. |
Sorry for not being more responsive, my time is limited and I first objective is to finalize sindresorhus/file-type#635, aiming release no Node.js dependent for file-type using the primary (non Node) entry point. |
Remove unused import Code style fixes
e8e3c9d
to
0960ff6
Compare
21d6627
to
75af653
Compare
800f855
to
cda25d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your commitment and hard work @bjornstar !
Part of v9.0.0 |
As you mentioned in Borewit/token-types#650 a good test is if we can use
token-types
(&file-type
) inmusic-metadata
.This is not exhaustive, there are still some Buffer usages remaining. However I have all the tests passing which I hope is good enough for a first pass.
I also discovered a race condition with the file-type parsing, we need to wait until the file type is parsed before we add the tags.
This PR depends on changes to:
uint8array-extras
strtok3
token-types
file-type