chore(deps): bump csharpier from 1.2.1 to 1.3.0 - #236
Open
NiklasArbin wants to merge 1 commit into
Open
Conversation
Held out of the dependency sweep in #231 because a formatter bump can reflow files repo-wide and should not ride along in another diff. It turns out to be nearly free: three null-coalescing operators move onto their own line, in two files. That comes from 1.2.2, "null coalescing is now consistently broken", which positions `??` on a new line rather than trailing the preceding method chain. Nothing else in the repo changes shape. Notably no XML reflow, which was the risk worth checking: 1.2.x replaced the XML parser and changed how empty lines and attribute encoding are handled, and 1.3.0 added strict/ignore whitespace modes. Every .csproj and .props file in the repo is already formatted the way 1.3.0 wants. 1.3.0 also renames --compilation-errors-as-warnings to --syntax-errors-as-warnings. Neither the CI workflow nor the pre-commit hook passes that flag, so nothing needed updating. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0176nyGkxqpWKrvJAEpwYtnx
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What this changes
Bumps the
csharpiertool in.config/dotnet-tools.jsonto 1.3.0 and applies the resulting reformat. Supersedes #224.This was deliberately held out of the dependency sweep in #231, on the grounds that a formatter bump can reflow files repo-wide and should not ride along inside another diff. It turns out to be nearly free — three null-coalescing operators move onto their own line, across two files:
That comes from 1.2.2, "null coalescing is now consistently broken", which puts
??on a new line rather than trailing the preceding method chain. Nothing else in the repo changes shape.Notes for the reviewer
No XML reflow, which was the risk worth checking. The 1.2.x line replaced CSharpier's XML parser and changed how empty lines between elements and attribute encoding are handled, and 1.3.0 added configurable strict/ignore XML whitespace modes. Given how much lives in
Directory.Packages.propsand the.csprojfiles, that could have been a large diff — but every XML file in the repo is already formatted the way 1.3.0 wants, including the wrapped multi-line<PackageVersion />elements.One renamed flag, not used here. 1.3.0 renames
--compilation-errors-as-warningsto--syntax-errors-as-warnings, and changes XML syntax errors to fail rather than pass through. Neitherdotnet.yamlnor the.githookspre-commit hook passes that flag, so nothing needed updating.Verification.
dotnet csharpier check .is clean,dotnet build KnightBus.slnx --configuration Releasesucceeds (only the pre-existingNU1510), and the full suite is 308/308 across 10 suites. The reformat touches an integration test file, which is why I ran the integration suites rather than just the unit ones.Docs-adjacent aside, not part of this PR:
csharpier check .from the repo root also walks.claude/, so a stale git worktree at.claude/worktrees/from-master(registered, pointing at the pre-restructure layout) shows up as two unformatted files locally. CI never sees it since it checks out fresh.git worktree remove .claude/worktrees/from-masterclears it if it is no longer wanted.Checklist
dotnet build KnightBus.slnxanddotnet testpass — 308/308 across 10 suitesdotnet csharpier check .passesdocs/is updated, if the change is user-visible — N/A, not user-visible<Version>is bumped in the affected.csprojandCHANGELOG.mdhas an entry — N/A, no package affected; the two reformatted files are cosmetic and change no compiled behaviour🤖 Generated with Claude Code
https://claude.ai/code/session_0176nyGkxqpWKrvJAEpwYtnx