Backup non-seamless data files #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Non-seamless servers do not use redis to store information about players, ships, or tribes. Instead they are stored in
.arktribe,.arkprofile, and.playerentitiesfiles. However, these files are not being backed up by atlas-server-tools.Solution
Add loops to copy each file into the backup folder and log any that failed, but do not abort the backup of any others.
Thoughts
I'm not in love with the loops, but I wanted to make sure we weren't competing with ATLAS writes like some of the other files. It runs fairly quickly in small servers.
Perhaps a setting should be introduced to the instance configuration files such as
isSeamlesswhich defaults to true if missing (or ifserverMapisn't Ocean), and only does some of these backups I've opened PRs for when it's false.