Support blend mode and better handling of transparency group XObjects#64
Merged
BobLd merged 2 commits intoBobLd:masterfrom Feb 11, 2026
Merged
Support blend mode and better handling of transparency group XObjects#64BobLd merged 2 commits intoBobLd:masterfrom
BobLd merged 2 commits intoBobLd:masterfrom
Conversation
PsykerUdot
commented
Feb 10, 2026
PsykerUdot
commented
Feb 11, 2026
Owner
|
@PsykerUdot thanks a lot for the great work here!! this is a major contribution I submitted a comment, keep me posted. I will update PdfPig with the latest pre-release and check Thanks again! |
BobLd
requested changes
Feb 11, 2026
BobLd
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and refactorings, focusing on blend mode support and better handling of transparency group XObjects (transparency groups are not yet implemented though).
SKPaintCacheto cache paints based on blend mode, removed the separate antialiasing paint fields, and updated all usages to pass blend mode explicitly. This enables correct rendering with different blend modes and improves paint reuse.IsAnnotationBelowTextlogic, as Highlight annotation normally has explicit appearence stream and blend modes are supported now.SkiaStreamProcessorno more responsible for background color. Modified theGetPageAsSKBitmapmethod to accept an optional background color, defaulting to white in tests and PNG export, and updated test helpers accordingly.createEmptyDiffImagemethod is fixed, so it doesn't dispose returned bitmap (this caused AccessViolationException when running tests).