Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(main): scopeless commits will be picked up now #74

Closed
wants to merge 1 commit into from
Closed

fix(main): scopeless commits will be picked up now #74

wants to merge 1 commit into from

Conversation

sruehl
Copy link
Contributor

@sruehl sruehl commented Nov 16, 2021 •
edited
Loading

Description

commits without scopes are not picked up. This PR solves this.

#11
#73

How Has This Been Tested

added a testcase for strip commits with a feat: something commit style. Test successful no regression.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Code follows the code style of this project.
  • Changes follow the CONTRIBUTING guidelines.
  • Update necessary documentation accordingly.
  • Lint and tests pass locally with the changes.
  • Check issues and pull requests first. You don't want to duplicate effort.

Other information

@boring-cyborg
Copy link

boring-cyborg bot commented Nov 16, 2021

Thanks for your first pull request!

hound[bot]
hound bot reviewed Nov 16, 2021
View reviewed changes
main.py
scope = re.findall(regex, head)[0]
if scope == '':
scope = 'all'
if scope.lower() == 'changelog' and regex == r'^docs(?:[(](.+?)[)])?':
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (82 > 79 characters)

@gitmagic-app
Copy link

gitmagic-app bot commented Nov 16, 2021

@sruehl - Your pull request does not follow our contribution guidelines. Please review the following issues and update.

pull request title must use proper <type> or <scope>.
<header> of commit message must use proper <type> or <scope>.

If you have any questions, please refer to our Contributing Guidelines or ask us here.

Thanks

@mergify
Copy link
Contributor

mergify bot commented Nov 16, 2021

Thanks for opening this pull request!
Please check out the Contributing Guidelines.

@mergify mergify bot assigned sruehl Nov 16, 2021
@mergify mergify bot requested a review from BobAnkh November 16, 2021 13:02
@mergify
Copy link
Contributor

mergify bot commented Nov 16, 2021

@sruehl
Wrong PR Title: fix: scopeless commits will be picked up now
Please check Contributing Guidelines for more information.

@mergify
Copy link
Contributor

mergify bot commented Nov 16, 2021

@sruehl
Contribution Message Convention Tests failed with GitMagic.
Please check details and Contributing Guidelines for more information.
If you don't want to correct it yourself, just tell the maintainers. They will do it when merging.

@sruehl sruehl changed the title fix: scopeless commits will be picked up now fix(main): scopeless commits will be picked up now Nov 16, 2021
@gitmagic-app
Copy link

gitmagic-app bot commented Nov 16, 2021

@sruehl - Your pull request does not follow our contribution guidelines. Please review the following issues and update.

<header> of commit message must use proper <type> or <scope>.

If you have any questions, please refer to our Contributing Guidelines or ask us here.

Thanks

@gitmagic-app
Copy link

gitmagic-app bot commented Nov 16, 2021

Everything looks good 👍

@sruehl
Copy link
Contributor Author

sruehl commented Nov 16, 2021

btw: @BobAnkh your gitmagic-app demands the optional scope too...

@sruehl sruehl mentioned this pull request Nov 16, 2021
Closed
@sruehl sruehl deleted the branch BobAnkh:master November 16, 2021 13:31
@sruehl sruehl closed this Nov 16, 2021
@sruehl sruehl deleted the master branch November 16, 2021 13:31
@sruehl sruehl restored the master branch November 16, 2021 13:32
@sruehl sruehl reopened this Nov 16, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 16, 2021

Thanks for opening this pull request!
Please check out the Contributing Guidelines.

@sruehl
Copy link
Contributor Author

sruehl commented Nov 16, 2021

Github apparently closes the PR when you rename your forks main branch. https://github.com/github/renaming

@sruehl
Copy link
Contributor Author

sruehl commented Nov 16, 2021

superseeded by #75

@sruehl sruehl closed this Nov 16, 2021
@sruehl sruehl deleted the master branch November 16, 2021 13:40
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue or pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hound hound[bot] hound[bot] left review comments

@BobAnkh BobAnkh Awaiting requested review from BobAnkh

Assignees

@sruehl sruehl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sruehl