Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(join): join header and body if necessary #25

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Conversation

BobAnkh
Copy link
Owner

@BobAnkh BobAnkh commented Oct 21, 2020

Description

Users may use ... at the end of the commit <header> when this line exceeds the characters limitation and use another ... at the beginning of the only line in the <body> section. When generating changelog, they should be join together.

Resolves: #16

How Has This Been Tested

Test locally. Also pass all existing pytest.

Screenshots(optional)

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • Code follows the code style of this project.
  • Changes follow the CONTRIBUTING guidelines.
  • Update necessary documentation accordingly.
  • Lint and tests pass locally with the changes.
  • Check issues and pull requests first. You don't want to duplicate effort.

Other information

@gitmagic-app
Copy link

gitmagic-app bot commented Oct 21, 2020

All sorted. 👍

@BobAnkh BobAnkh changed the title feat(join): join header and body if necessary feature(join): join header and body if necessary Oct 21, 2020
@mergify mergify bot added the enhancement New feature or request label Oct 21, 2020
@mergify
Copy link
Contributor

mergify bot commented Oct 21, 2020

All checks passed.
Please wait for review.

@codecov
Copy link

codecov bot commented Oct 21, 2020

Codecov Report

Merging #25 into master will decrease coverage by 1.53%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
- Coverage   24.32%   22.78%   -1.54%     
==========================================
  Files           2        2              
  Lines         148      158      +10     
==========================================
  Hits           36       36              
- Misses        112      122      +10     
Impacted Files Coverage Δ
main.py 15.86% <0.00%> (-1.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d5b424...ea31132. Read the comment docs.

@mergify
Copy link
Contributor

mergify bot commented Oct 21, 2020

All checks passed.
Please wait for review.

@mergify
Copy link
Contributor

mergify bot commented Oct 21, 2020

All checks passed.
Please wait for review.

@mergify mergify bot merged commit ec0bc48 into master Oct 21, 2020
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue or pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2020
@BobAnkh BobAnkh deleted the feature/join branch November 6, 2020 04:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[enhancement] join together the header and the only line in body when using ... in the message
1 participant