Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed door on cargoship and franklin fixes #153

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Conversation

NeenGame
Copy link
Contributor

No description provided.

@TheIndra55
Copy link
Collaborator

Thanks for working on this, this is great.

Sorry for taking a while to review this, I was on vacation and wanted to understand the changes. The changes seem fine, I however noticedr one thing when comparing the edits you made in stream/v_int_24.ytyp. It seems you increased the bounding sphere radius to a very large number from the original.

image

@NeenGame
Copy link
Contributor Author

NeenGame commented Sep 11, 2024

Thanks for working on this, this is great.

Sorry for taking a while to review this, I was on vacation and wanted to understand the changes. The changes seem fine, I however noticedr one thing when comparing the edits you made in stream/v_int_24.ytyp. It seems you increased the bounding sphere radius to a very large number from the original.

image

Yeah but it's fixed i am not map editor but when i can fix something that is broken i fix it if it's not the right way i can revert the franklin fixes to be only the cargo door i test everything it's not causing any crashes

i return it to the default no problem. Everything work fine

  • Before
    Screenshot 2024-08-29 025526
    Screenshot 2024-08-29 025532

  • After
    Screenshot 2024-08-29 025937
    Screenshot 2024-08-29 030139

@TheIndra55
Copy link
Collaborator

Seems still not right, but I'll fix it after merging.

@TheIndra55 TheIndra55 merged commit a234329 into Bob74:master Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants