Update riak-debug for Riak KV 3.x #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added OTP_VER to initial variables so that it can be included in the PKG_ID variable and thus the binary file name
Swapped underscores (not allowed by Ubuntu) for a hyphen. Removed hyphen from after OTP as the meaning is still clear without it.
Fix/bt props cli
Add tools application to include profiling modules.
Edit Makefile so package names include OTP version
Re-introduce capability to run `sudo riak debug` (not riak-debug). This is considered as a special case, and bypasses the standard relx generated riak start script. There were a number of issues with individual debug scripts related to permissions and the relative start location when running via he relx generated script. This adds back into riak the riaknostic library, allowing for `riak admin diag` to be run. The level of diagnostic checks supplied via this library are minimal at present though. The diagnostic checks will be run by default as part of `riak debug` Co-authored-by: Bob-The-Marauder <[email protected]>
* erl scripts Some riak admin scripts require an erlang node to be started, and then connected to the riak node (rather than using rpc). These scripts don't work in 3.0.1. $ERTS_PATH and $NAME_PARAM are not defined (as was previously defined in node_package); boot file - cannot find start.boot only start_clean.boot (for reasons unknown); observer not an installed application These changes work with OTP 20.3, OTP 21.3 and OTP 22.3. Tested using: `make rel` `rel/riak/bin/riak start` `rel/riak/bin/riak admin top` * Remove bespoke top formatter There was a special formatter for etop packaged within riak top. This may have been visually more appealing than the format for etop in OTP16? However, going forward want to take advantage of mainstream OTP improvements not rely on bespoke formatter. The bespoke formatter may not have been working anyway.
* Changes to support location * Tag and release notes for 3.0.5 * Update links and THANKS * Add help to location command Also, update tagging * Typo fix
Returns riak to pre-3.0 default of interactive mode, by setting a pre-start script. Should be possible to override by setting the environment variable before starting (if one wishes to run embedded). Required for user-added code (e.g. to find user-defined map/reduce functions)
Currently, when building rpm packages, riak-2.x.x names correctly e.g. `riak-2.9.8-1.el8.x86_64.rpm` but the riak-3.x.x rpms are missing a dot before the basearch i.e. `riak-3.0.6-1.el8x86_64.rpm`. This incredibly tiny fix re-adds the missing dot in the package name. I have already tested this successfully on one of the regular package builders we use to publish the binaries by creating a phony tag of riak-3.0.61 and building it accordingly: ``` [root@localhost riak]# ls rel/pkg/out/packages/ riak-3.0.61.OTP20.3-1.el8.src.rpm riak-3.0.61.OTP20.3-1.el8.x86_64.rpm riak-3.0.61.OTP20.3-1.el8.src.rpm.sha riak-3.0.61.OTP20.3-1.el8.x86_64.rpm.sha ```
* Update riak admin usage and examples to reflect changes Since the format of `riak-admin` was changed to `riak admin`, examples such as the usage prompt from running `riak admin` need to be corrected. * Update riak-admin
…asho#1079) Each time riak status (and the like) is run, relx generates a unique id which is then converted to an atom ("[email protected]") in riak VM, eventually causing atom table exhaustion. Relx has been modified to optionally generate a static id if NODETOOL_NODE_PREFIX env var is present. Convenient when the caller guarantees calls are always serialized. Co-authored-by: Andrei Zavada <[email protected]>
* Changes for Release 3.0.8 * Update rebar.lock * Update THANKS * Update lock for release
* Logging of 2i query performance * Update deps * Add release notes Initial preparation for Riak 3.0.9 release
Preparation for release 3.0.10. Uplift all changed deps to develop-3.0, add new schema controls, update release notes and readme. Minimum OTP version now OTP 22.
* Temp replace reip with reip_manual Reip was broken by the missing scripts necessary to generate the config so that erl could be run without the riak node active, but with the config necessary to load riak_core. Now loading riak_core is not necessary with riak_manual .. but both the path to the ring directory, and the cluster name need to be manually passed in as command params. * Update rebar.lock * Update branch
* planned combination for 3.0.13 basho/eleveldb#269 to be added once issues are resolved * Release preparation - 3.0.13 * For testing of fix to KV1847 * Update with reference to conditional PUT changes * Update riak-chkconfig As per basho#1125 * Update following merge * Tags for release
Release 3.0.14
* Update deps for 3.0.16 test * Update deps * Prepare for release Now with riak_core claim algorithm update * Add addendum to 3.0.12 release notes to highlight snappy issue * Update RELEASE-NOTES.md * Update to tagged repos
Bug fixes and feature improvement update - Fix a bug when retrieving leveled backend info. - Fix attempt for some OS which occasionally encounter a bug where `riak debug` attempts to write to the Riak data directory instead of the current folder. - Improve OS identification. - Avoid running blockdev on snapd mounts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fixes and feature improvement update
riak debugattempts to write to the Riak data directory instead of the current folder.Note the only file changed is riak-debug, I'm not sure why Github is including other commits in this PR.