This repository was archived by the owner on Feb 26, 2025. It is now read-only.
Feat: Add python dynamical feature registration #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaudon
force-pushed
the
register_features
branch
from
15c604f to
7bf673f
Compare
anilbey
reviewed
May 7, 2024
anilbey
approved these changes
May 7, 2024
|
it works in parallel, if register is done in the script, not under main . |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could made possible to try experimental new features, or very specific ones which don't make sense to be used in general, but for a very specific project.
It would be nice to make _get_cpp_data public, but I'm not sure if this is ok to do?