This repository was archived by the owner on Feb 26, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 41
Update Neo integration for NWB support #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anilbey
reviewed
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks great.
Could you address the following also:
- the name of the example can be more explicit perhaps
nwb-via-neo
orload-nwb
or something similar - If possible, in the notebook besides the interspike interval, could you show at least one other feature? The sonata-network notebook is also showing the interspike interval feature. Some different feature/features would be good to show on the experimental data. E.g. perhaps some burst related feature as Rajnish mentioned. cc @darshanmandge which features may be suited for this experimental NWB
- Could you modify the docs/examples_to_rst.sh script @AurelienJaquier had created to make sure this notebook will be rendered in the docs?
Thanks @ilkilic ! You can use this burst related features: spikes_per_burst, strict_burst_number, strict_burst_mean_freq |
I have made the requested changes in the latest commits |
Wow looks so good, thanks a lot @ilkilic |
anilbey
approved these changes
Apr 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates NEO integration to support NWB formats and introduces a new example that demonstrate how to load data with NEO.
Checklist: