Skip to content
This repository has been archived by the owner on Feb 26, 2025. It is now read-only.

Add Sonata example #361

Merged
merged 17 commits into from
Feb 14, 2024
Merged

Add Sonata example #361

merged 17 commits into from
Feb 14, 2024

Conversation

ilkilic
Copy link
Collaborator

@ilkilic ilkilic commented Jan 22, 2024

No description provided.

@ilkilic ilkilic self-assigned this Jan 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c70d471) 66.22% compared to head (180b161) 66.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #361   +/-   ##
=======================================
  Coverage   66.22%   66.22%           
=======================================
  Files          33       33           
  Lines        6504     6504           
  Branches     2279     2279           
=======================================
  Hits         4307     4307           
  Misses        273      273           
  Partials     1924     1924           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ilkilic ilkilic marked this pull request as draft February 7, 2024 09:25
@ilkilic ilkilic marked this pull request as ready for review February 7, 2024 13:07
@ilkilic ilkilic requested a review from anilbey February 7, 2024 13:07
Copy link
Contributor

@anilbey anilbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic! Great work.

Could you also mention the following information at the very beginning of the notebook:

@anilbey
Copy link
Contributor

anilbey commented Feb 14, 2024

Brilliant, looks very good. Could you just add the cell ids on the last 3 plots on the plot titles?

@anilbey
Copy link
Contributor

anilbey commented Feb 14, 2024

Okay the last request :)

Let's show also a spike_event feature. Could you plot the inter-spike-intervals in another plot at the bottom of the notebook?

You can use the "all_ISI_values" feature to get all the time differences btw. the spikes.

https://efel.readthedocs.io/en/latest/eFeatures.html#libv5-all-isi-values

It should look like this: https://efel.readthedocs.io/en/latest/_images/inv_ISI.png

There is no need to name them first_ISI, second_ISI but it would be great to add their numeric values on the horizontal lines. E.g. 12ms, 10ms.

Thanks

@ilkilic ilkilic merged commit 1c02c12 into master Feb 14, 2024
9 checks passed
@ilkilic ilkilic deleted the example-sonata branch February 14, 2024 15:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants