This repository has been archived by the owner on Dec 11, 2023. It is now read-only.
introduction of an abstraction layer for the "results array" #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 5, 2015
| bcolz.ctable._outstruc_fromindices = value.fromindices | ||
| bcolz.ctable._outstruc_fromboolarr = value.fromboolarr | ||
| assert hasattr(value, '__setitem__') | ||
| except AttributeError, AssertionError: |
There was a problem hiding this comment.
Parenthesis are needed for Python 3
|
I need to think a bit more on this, but at least initially this seems like a good idea to me. |
ARF1
force-pushed
the
out_structure_abstraction_layer
branch
from
b15ba87 to
a8fee6c
Compare
ARF1
force-pushed
the
out_structure_abstraction_layer
branch
from
a8fee6c to
8ff5422
Compare
This allows implementations of the abstraction layer to cache their data structures just like we currently do for numpy
ARF1
force-pushed
the
out_structure_abstraction_layer
branch
from
8ff5422 to
f5bcd90
Compare
added 2 commits
May 6, 2015 15:51
* tuples are created from the list of fields in a row only in the numpy implementation of the abstraction layer. Other implementation might be able to use the list instead without the expense of the conversion. * use list instead of set for the `weakref.WeakSet` work-around
|
Tests? |
|
I think that this would definitely be a nice addition. We still need tests and update the documentation so that user "may bring their own implementation". @ARF1 could you please do that? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implicitly closes #66 and #176 by allowing users to "bring their own" implementations.
Would benefit from #189.
This introduces an abstraction layer for the generation of the "results array" in
ctable.__getitem__()and for data access.It has minor impact on core
bcolzcode and minimizes overhead using lookup optimizations:Without abstraction layer:
With abstraction layer: