Only process local files with gcov#208
Merged
roconnor-blockstream merged 1 commit intomasterfrom Dec 1, 2023
Merged
Conversation
The 23.11 release of NixOS has caused GCC to mangle __FILE__ names withing the nix-store. See <NixOS/nixpkgs#255192>. This causes gcov to fail with file-not-found errors: (DEBUG) Running gcov: 'gcov /build/source/rsort.gcda --branch-counts --branch-probabilities --demangled-names --hash-filenames --object-directory /build/source' in '/build/source' (ERROR) GCOV produced the following errors processing /build/source/rsort.gcda: Cannot open source file /nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-glibc-2.38-27-dev/include/bits/string_fortified.h To work around this issue we add the --relative-only flag to gcov instucting it to not consider files with absoulte paths, thus excluding header files in the nix-store. Note: these files were already filtered out by gcovr, so the resulting documentation hasn't really changed.
apoelstra
approved these changes
Nov 30, 2023
uncomputable
approved these changes
Dec 1, 2023
Contributor
uncomputable
left a comment
uncomputable
left a comment
There was a problem hiding this comment.
ACK 5dc2acd nix-build -A c --arg withCoverage true works on NixOS version 23.11.20231129.50aa30a (Tapir)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 23.11 release of NixOS has caused GCC to mangle
__FILE__names withing the nix-store. See NixOS/nixpkgs#255192. This causes gcov to fail with file-not-found errors:To work around this issue we add the --relative-only flag to gcov instucting it to not consider files with absoulte paths, thus excluding header files in the nix-store.
Note: these files were already filtered out by gcovr, so the resulting documentation hasn't really changed.