Skip to content

sync-upstream: Restore SYNC_PAT#353

Merged
real-or-random merged 1 commit intoBlockstreamResearch:masterfrom
mllwchrry:restore-sync-pat
Mar 30, 2026
Merged

sync-upstream: Restore SYNC_PAT#353
real-or-random merged 1 commit intoBlockstreamResearch:masterfrom
mllwchrry:restore-sync-pat

Conversation

@DarkWindman
Copy link
Copy Markdown
Contributor

This PR restores the SYNC_PAT requirement due to restrictions on opening PRs with the default 'GITHUB_TOKEN'.

Since the authorship of the PR is now linked to the user who created the PAT, a note was added to the PR body to clarify that it was created by a GitHub Actions workflow and not by a human being.

Additionally, the permissions: section has been removed, as GITHUB_TOKEN is no longer in use.

Comment thread contrib/sync-upstream.sh Outdated

TITLE="Upstream PRs"
BODY=""
BODY="This PR has been created by a GitHub Actions workflow."$'\n'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this conditional on the GITHUB_ACTIONS env variable being defined?

Suggested change
BODY="This PR has been created by a GitHub Actions workflow."$'\n'
BODY="${GITHUB_ACTIONS+This PR has been created by a GitHub Actions workflow without human involvement.}"$'\n'

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! I have tested it both on GitHub and locally, and it works correctly.

P.S. Sorry for being out sick for so long...

Copy link
Copy Markdown
Member

@real-or-random real-or-random left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e371ab5

@real-or-random real-or-random merged commit 08d1cd0 into BlockstreamResearch:master Mar 30, 2026
122 checks passed
@real-or-random
Copy link
Copy Markdown
Member

Ok, works again: #356 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants