include: add description of range proofs#328
Conversation
real-or-random
left a comment
real-or-random
left a comment
There was a problem hiding this comment.
Please take all my comments as suggestions, and feel free to modify and deviate. (I tend to be picky about writing... )
|
Did you mean to push an update? The branch is still at the original version. |
|
Yes, sorry, thought I've pushed the changes. P. S. I'm honestly not sure why did the PR close automatically. |
real-or-random
left a comment
real-or-random
left a comment
There was a problem hiding this comment.
I like that version!
Now that we've figured out, meanwhile, that what goes into the hashes is also different from the paper (the malleability discussion), can you mention this difference, too?
| * embedded and recovered within maximally-sized proofs. The implemented embedding | ||
| * method using the forged parts of ring signatures could also be applied to the | ||
| * construction in the paper, but is not mentioned there. | ||
| * This feature is used in Confidential Assets to transmit values and blinding |
There was a problem hiding this comment.
Just a nit:
Does this line start a new paragraph or not? (If yes, there should be an empty line. If no, the paragraph should be "realigned".)
Either is fine, but if you touch this anyway, I suggest replacing "This feature" by "The message embedding feature" or just "Message embedding" to make it clear what it refers to (because the preceding sentence talks about the relation to the paper instead.)
There was a problem hiding this comment.
Meant it like a single paragraph, so realigned, thanks. And replaced "this feature" with "message embedding".
|
Forgot to mention this: can you also squash everything in a single commit? |
luckyNik
force-pushed
the
rangeproofs-description
branch
from
acf0bd2 to
da8d478
Compare
|
Ah, sorry, one last thing: There are a bunch of trailing spaces. Could you remove these? It's really not essential, but it's a bit cleaner to omit these, and some projects insist on omitting trailing whitespace, so it's a good opportunity to configure your editor to show these (or even remove automatically) |
…between the implementation and the CA paper
luckyNik
force-pushed
the
rangeproofs-description
branch
from
da8d478 to
6f7c112
Compare
Yep, no problem. Thanks for the hint, will check for those in the future. |
2 participants
Added the description of range proofs in Confidential Assets focusing on the differences between the description in the paper and the actual implementation.