Build and test wasm on MacOS in CI #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaseizinger
suggested changes
Jul 15, 2021
rishflab
force-pushed
the
mac-os-build
branch
2 times, most recently
from
8e9f7f7
to
05e62c4
Compare
thomaseizinger
suggested changes
Jul 16, 2021
rishflab
force-pushed
the
mac-os-build
branch
4 times, most recently
from
329f057
to
e25fd0d
Compare
The default clang installation provided in MacOS does not work. We fixed this locally by installing clang via llvm through brew and setting the CC and AR env variables to point at the new clang installation.The CI MacOS image seems to already have llvm installed so we did not need to install llvm on the CI. See rust-bitcoin/rust-secp256k1#254 for more details
thomaseizinger
approved these changes
Jul 20, 2021
There was a problem hiding this comment.
Looks good from my side! Thanks for sticking with this @rishflab :)
@jonasnick / @sanket1729 Do you mind having a look at this?
jonasnick
reviewed
Jul 20, 2021
The |
|
Sorry, missed your answer. Ok. |
|
Thank you for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default clang installation provided in MacOS does not work. We fixed
this locally by installing clang via llvm through brew and setting the
CC and AR env variables to point at the new clang installation.The CI
MacOS image seems to already have llvm installed so we did not need to
install llvm on the CI.
See rust-bitcoin/rust-secp256k1#254 for more
details