This repository was archived by the owner on Nov 28, 2019. It is now read-only.
validation: change pindexPrev->nHeight + 1 to nHeight #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
nice catch, we shouldn't hit this anyways but bad idea what we're doing. |
Collaborator
|
utACK |
Contributor
Author
|
Code rebased to make clear what we're doing. |
Contributor
|
utACK, wonder why that permissive NULL check was there, though.. |
Collaborator
|
Genesis block. We don't validate the Genesis block though.
…On Fri, Nov 9, 2018, 7:38 AM Steven Roose ***@***.*** wrote:
utACK, wonder why that permissive NULL check was there, though..
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFgC00jZQ_cAabqljENW8BtvPzXtOKu_ks5utXdWgaJpZM4YT3cA>
.
|
Collaborator
|
re-utACK, I'm going to cherry-pick this against elements as a forward port to run it through travis |
Collaborator
|
ElementsProject/elements#464 awaiting travis run here |
Collaborator
|
Passed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
validation: change pindexPrev->nHeight + 1 to nHeight