feat: support testnet4 #144
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoedberg
changed the title
|
what's next for this PR? how can we help get this merged so esplora can have testnet4 support? |
|
The PR is waiting for a review. As soon as this gets merged I will open a PR on https://github.com/Blockstream/esplora/ (esplora code is ready but it requires electrs code to be merged into the default branch). |
pseudozach
approved these changes
Mar 26, 2025
There was a problem hiding this comment.
lgtm
@RCasatta would you have time to take a look please and thank you 🙏
PR is just adding testnet4 related ports and variables afaict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have rebased the code from #91 since that has merge conflicts and it seems it's dormant since 2 months. I also removed some changes that I think were not necessary (probably there to update rust-bitcoin, which has been already done on the updated tip) and formatted the code with the latest Rust stable version. Moreover I would have renamed the existing
Testnetvariant toTestnet3, but this is not a decision I should take so let me know if this looks good to you or if you want me to make some changes.