Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few Modification #6

Open
wants to merge 4 commits into
base: test
Choose a base branch
from
Open

Few Modification #6

wants to merge 4 commits into from

Conversation

c-n-o-t-e
Copy link

Issue encountered
After deployment, function rateMember failed to assign accumulated point to rated member.

Suggested Solution

Replace Member memory memberStruct = members[__member] with just members[__member] in function addMember, whiteListMember, blackListMember, isWhiteListed.

Replace Member memory memberStruct = members[__membertorate] with just members[__membertorate] in function rateMember

Pending/brainstorming Issue
When an admin/owner rates a member, the accumulated point issued is 1 not 3.

…ated point to rated member. Suggested Solution Replace with just in function addMember, whiteListMember, blackListMember, isWhiteListed. Replace with just in function rateMember Pending/brainstorming Issue When an admin/owner rates a member, the accumulated point issued is 1 not 3.
@c-n-o-t-e
Copy link
Author

added else if to function rateMember.

removed isWhiteListed in function rateMember since require(admins[msg.sender] || isWhitelisted(msg.sender) is already in the function.

changed amount of points to equal 1 star from 10 to 15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant