feat: modules gpio.Button and gpio.Switch #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jens Drenhaus <[email protected]>
Signed-off-by: Jens Drenhaus <[email protected]>
Signed-off-by: Jens Drenhaus <[email protected]>
With the current abstraction the backend implementations of the GPIO module include business logic. The backend abstracted the button and switch, not the GPIO operation. Thus, the code of the module itself are just shallow pass-through modules and new backends would need to implement the business logic of button and switch again. This refactoring lifts the business logic into the actual functions of the GPIO modules and changes the interface of the backend to only abstract the pure GPIO operation. Signed-off-by: Jens Drenhaus <[email protected]>
This mock implementation of a dutagent session, that is passed to modules in the Run() method, can be used for modules' unit tests. Signed-off-by: Jens Drenhaus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the first "useful" feature to the project. See #6 for some discussions about the technique to use to manipulate the GPIO pins. I came up with an approach that allows to potentially use any of the discussed solutions within the model and make it configurable.
For now, there is only one such backend implemented, which is memory mapping
dev/mem.pkg/module/gpio/gpio.goimplements the general modulespkg/module/gpio/devmem.goimplements the backendCloses #6