Fix bug with BlazoredModalInstance SetTitle with nested modals #572
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found a problem with raising nested modals on a page, specifically where the title of the "parent" modal has been set with
SetTitle()
.You can reproduce the problem by trying the following in your Blazored.Modal BlazorWebAssembly sample project:
MultipleModals.razor
, see how you are opening a first Modal :Modal.Show<YesNoPrompt>("First Modal");
YesNoPrompt
component, to change its own Modal Title :protected override void OnInitialized() { BlazoredModal.SetTitle("First Modal v2"); }
Now do this:
I believe this is due to the original
Title
parameter being automatically reset by Blazor's RenderFragment mechanism.So, my fix in this pull request is to use a private
_title
variable in the modal instance, which is written to once only by the Parameter, and subsequently only modified by use of theSetTitle
method. Please let me know what you think.Cheers, James