Feature/decimal support using float #1589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f dataframe that has decimal columns
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
wmalpica
approved these changes
Aug 4, 2021
felipeblazing
requested changes
Aug 4, 2021
| for(size_t column_i = 0; column_i < column_indices.size(); column_i++) { | ||
| col_names[column_i] = schema.get_name(column_indices[column_i]); | ||
| cudf::type_id type_id = schema.get_dtype(column_indices[column_i]); |
There was a problem hiding this comment.
How is this checking for decimals here its checking for float64. What if the file had contained a float64 and not a decimal?
There was a problem hiding this comment.
I ask because you do decimal_cols.emplace_back below
There was a problem hiding this comment.
I had the same question and verified the it works just fine if there are floats and decimals or just one or just the other.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1588