-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add midi output support #12
Conversation
Amazing! 🤩 I got time to look at this on Sunday, can you run the |
Done! I'm also thinking about submitting a PR to change how |
Sure, I'll look at it in detail Sunday. I think a group plugin would also be nice, grouping both input and output called Midi (thus only needing users to change from |
I think a group plugin would make sense, but it should probably be named |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this is some really amazing work and a huge improvement of the ergonimics! Though I think we can improve it even further. Though time is always a factor. I think we should move this pr into a new branch as part of an overhaul instead and then when we think we are done, then it merged in, just like with Leafwing-Studios/leafwing-input-manager#164. What do you think?
Co-authored-by: Mikkel Rasmussen <[email protected]>
Co-authored-by: Mikkel Rasmussen <[email protected]>
I'm down for moving this pr to a branch and working on it there. Though I just realised that maybe |
Amazing! I've added the branch 0.6 so that you can now change the target branch of this pr :) |
Objective