-
-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bruno: add package #4360
base: master
Are you sure you want to change the base?
bruno: add package #4360
Conversation
packages/bruno/PKGBUILD
Outdated
url="https://www.usebruno.com/" | ||
license=('MIT') | ||
_electron=electron31 | ||
depends=( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure but there is maybe a style issue here, it should be horizontal until 80 chars.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
packages/bruno/PKGBUILD
Outdated
# Old Maintainer: Vianney Bouchaud <aur dot vianney at bouchaud dot org> | ||
|
||
pkgname=bruno | ||
pkgver=1.34.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, we mostly do git packages instead of release ones, could you adapt from the AUR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
# lets be sure we are starting clean | ||
which nvm >/dev/null 2>&1 && nvm deactivate && nvm unload | ||
|
||
export NVM_DIR="${srcdir}/${pkgname}-${pkgver}/.nvm" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IS nvm really needed to build an electron app?
https://wiki.archlinux.org/title/Electron_package_guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noted if I remove it, I get an error when I run bruno
:
Preferences file is located at: /home/athena/.config/bruno/preferences.json
(node:533907) electron: Failed to load URL: file:///usr/lib/bruno/web/index.html with error: ERR_FILE_NOT_FOUND
(Use `electron --trace-warnings ...` to show where the warning was created)
Error: Failed to load URL: "file:///usr/lib/bruno/web/index.html" (Electron shows a blank screen because of this).
Original message: Error: ERR_FILE_NOT_FOUND (-6) loading 'file:///usr/lib/bruno/web/index.html'
at rejectAndCleanup (node:electron/js2c/browser_init:2:79183)
at WebContents.finishListener (node:electron/js2c/browser_init:2:79345)
at WebContents.emit (node:events:519:28) {
errno: -6,
code: 'ERR_FILE_NOT_FOUND',
url: 'file:///usr/lib/bruno/web/index.html'
}
If you are using an official production build: the above error is most likely a bug! Please report this under: https://github.com/usebruno/bruno/issues
According to the AUR maintainer, nvm
is needed to be sure that we build the package with the same nodejs version used upstream.
Close #4097