Skip to content

fix(db): harden migration recovery snapshots - #13

Draft
Bl0ck154 wants to merge 2 commits into
integrate/upstream-db-safetyfrom
integrate/upstream-db-migrations
Draft

Bl0ck154 wants to merge 2 commits into
integrate/upstream-db-safetyfrom
integrate/upstream-db-migrations

Conversation

@Bl0ck154

Copy link
Copy Markdown
Owner

Stacked on PR #12 (integrate/upstream-db-safety). Production is not changed by this draft PR.

Included

Adaptation to our branch

  • preserved our existing safe-init wrapper around DB initialization
  • passed databaseExistedBeforeInitialization into the new migration runner without replacing our newer startup logic
  • kept our actual 28-entry RENAMED_MIGRATION_COMPATIBILITY table instead of importing four unrelated later release-tip renames; tests were adjusted to our real table ordering
  • did not pull unrelated plugin-directory docs from the newer release tip

Validation

  • 40/40 focused migration/backup/data-dir tests pass
  • npm run typecheck:core: pass
  • npm run check:db-rules: pass
  • npm run check:env-doc-sync: pass
  • eslint on the migration/core/data-path files touched here: pass
  • git diff --check: pass

diegosouzapw and others added 2 commits September 20, 2026 09:31
Validado em lote numa worktree combinada com os 14 PRs desta campanha de error-boundary sobre o tip de `release/v3.8.51`: `typecheck:core` limpo e **120/120** nos 23 arquivos de teste que os PRs trazem.

Um ponto que só apareceu no tree combinado: **diegosouzapw#12465 e diegosouzapw#12466 criam o mesmo arquivo novo** `open-sse/utils/streamReadiness.ts` (que não existe no tip) com desenhos divergentes de cancelamento — `cancelled` + `releaseLock` imediato num, `readInFlight`/`cancelRequested` com `cancelReader` fire-and-forget no outro. Adotei a versão do diegosouzapw#12466, que difere e defere o release do lock para quando a leitura em voo termina, e validei a escolha rodando as suítes dos **dois** PRs contra ela: 21/21 no readiness compartilhado e 22/22 incluindo o boundary do Perplexity.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants