fix socket exhaustion, change address to interpolated strings

BitesizedLion · Dec 18, 2022 · b4a1267 · b4a1267
1 parent 92bfd16
commit b4a1267
Show file tree

Hide file tree

Showing 9 changed files with 12 additions and 13 deletions.
diff --git a/...a41d5ce-9231-4b56-a8e1-32bf1096a40e.vsidx → ...fcbb1cd-99dd-4196-acb8-a65cde1827d3.vsidx b/...a41d5ce-9231-4b56-a8e1-32bf1096a40e.vsidx → ...fcbb1cd-99dd-4196-acb8-a65cde1827d3.vsidx
diff --git a/.vs/TidalRPC/FileContentIndex/22a8d5fa-e7ae-4921-9d55-25410ff15810.vsidx b/.vs/TidalRPC/FileContentIndex/22a8d5fa-e7ae-4921-9d55-25410ff15810.vsidx
diff --git a/.vs/TidalRPC/FileContentIndex/45490598-878b-4166-8e08-6daac237468c.vsidx b/.vs/TidalRPC/FileContentIndex/45490598-878b-4166-8e08-6daac237468c.vsidx
diff --git a/.vs/TidalRPC/FileContentIndex/59177860-53d6-4ebb-aac4-a39077817d7f.vsidx b/.vs/TidalRPC/FileContentIndex/59177860-53d6-4ebb-aac4-a39077817d7f.vsidx
diff --git a/.vs/TidalRPC/FileContentIndex/b80e119e-1f91-4338-a5da-2859c8a70292.vsidx b/.vs/TidalRPC/FileContentIndex/b80e119e-1f91-4338-a5da-2859c8a70292.vsidx
diff --git a/Program.cs b/Program.cs
@@ -62,8 +62,6 @@ static void Main()
             client.Dispose();
         }
 
-
-
         static async Task StartWebServer()
         {
             var listener = new HttpListener();

diff --git a/Properties/AssemblyInfo.cs b/Properties/AssemblyInfo.cs
@@ -8,9 +8,9 @@
 [assembly: AssemblyTitle("TidalRPC")]
 [assembly: AssemblyDescription("")]
 [assembly: AssemblyConfiguration("")]
-[assembly: AssemblyCompany("")]
+[assembly: AssemblyCompany("BitesizedLion")]
 [assembly: AssemblyProduct("TidalRPC")]
-[assembly: AssemblyCopyright("Copyright ©  2022")]
+[assembly: AssemblyCopyright("Copyright © BitesizedLion 2022-")]
 [assembly: AssemblyTrademark("")]
 [assembly: AssemblyCulture("")]
 
@@ -32,5 +32,5 @@
 // You can specify all the values or you can default the Build and Revision Numbers
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
-[assembly: AssemblyVersion("1.0.0.0")]
-[assembly: AssemblyFileVersion("1.0.0.0")]
+[assembly: AssemblyVersion("1.0.1.1")]
+[assembly: AssemblyFileVersion("1.0.1.1")]
diff --git a/UpdateManager.cs b/UpdateManager.cs
@@ -50,16 +50,17 @@ public static void ToggleUpdateCheck(bool checkForUpdates)
         // Method for checking for new updates
         public static async Task CheckForUpdates()
         {
+            // Get the current application version
+            Version currentVersion = Assembly.GetExecutingAssembly().GetName().Version;
+
+            HttpClient client = new HttpClient();
+            client.DefaultRequestHeaders.UserAgent.ParseAdd("tidalrpc/" + currentVersion.ToString()); // GH api needs custom user-agent
+
             while (!updateDenied)
             {
                 if (!IsUpdateCheckEnabled()) return;
 
-                // Get the current application version
-                Version currentVersion = Assembly.GetExecutingAssembly().GetName().Version;
-
                 // Fetch the latest release information from the GitHub API
-                HttpClient client = new HttpClient();
-                client.DefaultRequestHeaders.UserAgent.ParseAdd("tidalrpc/" + currentVersion.ToString()); // GH api needs custom user-agent
                 HttpResponseMessage response = await client.GetAsync("https://api.github.com/repos/BitesizedLion/TidalRPC/releases/latest");
 
                 if (response.IsSuccessStatusCode)

diff --git a/Utils.cs b/Utils.cs
@@ -40,12 +40,12 @@ public static string GetAddress()
             if (!File.Exists(filePath))
             {
                 Console.WriteLine("GetAddress: coreProps does not exist, returning default address");
-                return "http://127.0.0.1:3650";
+                return "http://127.0.0.1:3650/";
             }
 
             string jsonString = File.ReadAllText(filePath);
             dynamic json = JsonConvert.DeserializeObject(jsonString);
-            string address = "http://"+json.address+"/";
+            string address = $"http://{json["address"]}/";
 
             return address;
         }