Skip to content
This repository has been archived by the owner on Apr 8, 2022. It is now read-only.

Time picker #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Time picker #1

wants to merge 3 commits into from

Conversation

alpgarcia
Copy link

Documentation for Kibanas' Time Picker.

@alpgarcia alpgarcia requested a review from dicortazar June 26, 2018 13:06
timepicker.md Outdated
explained in the following sections.

## Quick Mode
This moder allows to quickly select among a set of predefined time ranges.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moder?

@@ -0,0 +1,51 @@
# Time Picker
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to add other sections with the usual issues when having the timepicker? For instance, by default that's fixed at the last 15 minutes.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, because this is a configurable thing. It might be interesting to tell that, and also note that some panels can have its own value by default, i.e., there are two default values:

  • Panel level
  • Dashboard/Kibana level. This will be overiden by the previous one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, adding that information would be more complete.

Copy link
Member

@dicortazar dicortazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks a lot. I've commented a couple of things I'd like you to review.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants