-
Notifications
You must be signed in to change notification settings - Fork 1
Time picker #1
base: master
Are you sure you want to change the base?
Time picker #1
Conversation
timepicker.md
Outdated
explained in the following sections. | ||
|
||
## Quick Mode | ||
This moder allows to quickly select among a set of predefined time ranges. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moder?
@@ -0,0 +1,51 @@ | |||
# Time Picker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to add other sections with the usual issues when having the timepicker? For instance, by default that's fixed at the last 15 minutes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, because this is a configurable thing. It might be interesting to tell that, and also note that some panels can have its own value by default, i.e., there are two default values:
- Panel level
- Dashboard/Kibana level. This will be overiden by the previous one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, adding that information would be more complete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks a lot. I've commented a couple of things I'd like you to review.
Documentation for Kibanas' Time Picker.