Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to a better variant of DKLs #5767

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Switch to a better variant of DKLs #5767

wants to merge 2 commits into from

Conversation

bitgo-keenan
Copy link

@bitgo-keenan bitgo-keenan commented Mar 13, 2025

Description

This PR switches to a better variant of DKLs threshold ECDSA signing that has become available. No API is changed. This will enable performance improvements in the signing API.

Issue Number

n/a

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Simply with yarn run test in the sdk-lib-mpc module.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My code compiles correctly for both Node and Browser environments
  • I have commented my code, particularly in hard-to-understand areas
  • My commits follow Conventional Commits and I have properly described any BREAKING CHANGES
  • The ticket or github issue was included in the commit message as a reference
  • I have made corresponding changes to the documentation and on any new/updated functions and/or methods - jsdoc
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@islamaminBitGo
Copy link
Contributor

Tested locally with SDK and made sure it compiles and runs on the browser.
Txn from browser: https://holesky.etherscan.io/tx/0xa239c4818c6f6767e9111657aab9fe91f45d62d032d1b0b9da3c01c6cf114eff
Txn from local SDK: https://holesky.etherscan.io/tx/0x102a7e43bbab1d588ed1a3472f7dbc0da802cd7e1a575cfff30cdfbac5282bd7,

@islamaminBitGo islamaminBitGo marked this pull request as ready for review March 26, 2025 01:11
@islamaminBitGo islamaminBitGo requested review from a team as code owners March 26, 2025 01:11
@islamaminBitGo islamaminBitGo marked this pull request as draft March 26, 2025 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants