Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More known U2F App IDs #472

Merged
merged 1 commit into from
Apr 27, 2020
Merged

More known U2F App IDs #472

merged 1 commit into from
Apr 27, 2020

Conversation

jengo9332
Copy link

BitBox02 showing "Unknown site: " on almost every application except Google & Github.
This request adds more U2F names when authenticating.

benma
benma requested changes Apr 21, 2020
View reviewed changes
Copy link
Collaborator

@benma benma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, this is highly appreciated.

Please also run ./scripts/format in the end to run clang-format on the code.

src/u2f/u2f_app.c Outdated Show resolved Hide resolved
src/u2f/u2f_app.c Outdated Show resolved Hide resolved
src/u2f/u2f_app.c Show resolved Hide resolved
src/u2f/u2f_app.c Show resolved Hide resolved
@benma
Copy link
Collaborator

benma commented Apr 21, 2020

Oh and please sign your commits if you can :)

@jengo9332 jengo9332 requested review from benma and x1ddos April 22, 2020 17:21
x1ddos
x1ddos reviewed Apr 22, 2020
View reviewed changes
Copy link
Contributor

@x1ddos x1ddos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All new entries look ok except the two.
Verified locally URLs match App ID hashes.

src/u2f/u2f_app.c Outdated Show resolved Hide resolved
src/u2f/u2f_app.c Outdated Show resolved Hide resolved
benma
benma requested changes Apr 24, 2020
View reviewed changes
Copy link
Collaborator

@benma benma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed all the hashes. Need to still test facebook, other than that this looks good to go.

Thanks for the nice cleanup.

src/u2f/u2f_app.c Outdated Show resolved Hide resolved
@jengo9332 jengo9332 requested a review from benma April 25, 2020 10:20
@jengo9332
Copy link
Author

Alright, added Tutanota as the last entry.
I think it all should be good now.

@benma
Copy link
Collaborator

benma commented Apr 27, 2020

Alright, added Tutanota as the last entry.
I think it all should be good now.

Thanks. Final step: please squash all commits, so the commit history does not have a lot of small fixup commits.

@STDSU @jengo9332
More known U2F App IDs
ee20936 
fix code typo

clang format

Added a few sha256 to the list, lacking fb and fedora

clean dupes & add verified sha256

Add Dashlane to the list

Revert "Add Dashlane to the list"

This reverts commit 06d9d0f.

Add Dashlane to the list

Add U2F bin coffee

Add AWS

Removed Duo from the list

Remove Dashlane dupe

Add Tutanota

Remove Facebook until FIDO2 support has been added
@jengo9332
Copy link
Author

Alright, added Tutanota as the last entry.
I think it all should be good now.

Thanks. Final step: please squash all commits, so the commit history does not have a lot of small fixup commits.

Ok, done

@benma benma merged commit 98eecf3 into BitBoxSwiss:master Apr 27, 2020
@benma
Copy link
Collaborator

benma commented Apr 27, 2020

Thanks again!

@NickeZ NickeZ mentioned this pull request Apr 27, 2020
Open
@jengo9332 jengo9332 deleted the U2F_Keys_Known_Apps branch May 6, 2020 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@x1ddos x1ddos x1ddos left review comments

@benma benma Awaiting requested review from benma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jengo9332 @benma @x1ddos @STDSU