Switch to GCC 13 #1273
Draft
Switch to GCC 13 #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benma
approved these changes
Aug 15, 2024
CMakeLists.txt
Outdated
| @@ -224,7 +224,7 @@ configure_file(src/bootloader/bootloader_version.h.in src/bootloader/bootloader_ | |||
| string(APPEND CMAKE_C_FLAGS " -std=c11 -pipe") | |||
| if(CMAKE_CROSSCOMPILING) | |||
| set(CMAKE_C_FLAGS "\ | |||
| ${CMAKE_C_FLAGS} -mcpu=cortex-m4 -mthumb -mlong-calls \ | |||
| ${CMAKE_C_FLAGS} -mcpu=cortex-m4 -mthumb -mlong-calls -mno-unaligned-access \ | |||
There was a problem hiding this comment.
Is this safe, or does this introduce risk? If it's safer to not use this flag we could postpone using this trick until we need to save bytes more urgently.
There was a problem hiding this comment.
Yeah, not sure what the impact is. I think unaligned accesses can be problematic on some platforms, so I would assume that no unaligned access would be safer than allowing it.
|
I will wait this this PR until I have some other CI related things merged and I've tested the device. |
|
Firmware doesn't work. It doesn't pop up the "unlock" screen. |
Thompson1985
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reduce the size of the binary a bit we add -mno-unaligned-access because that made struct initialization generate quite a lot more code.
In the new toolchain
assertis defined as a macro. That interferes with the ASF function calledassertso we undefined it right before that function is defined.We also have to provide the search path to the linker to our dummy files libssp and libssp_nonshared. The actual implementation of the stack protector functions are in common_main.c.