frontend: replace BrowserRouter with HashRouter #2524
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the BrowserRouter is needlessly complicated, we don't need the browser to make a new "request" when we route to a different page. Getting this to work is especially difficult in iOS, where the file path to index.html is loaded in the webview, and routing to e.g. `/account-summary' fails because the absolute filepath `/account-summary` does not exist and is outside the app folder sandbox. Using the hash router instead, where the app path is tracked behind the `#` (e.g. index.html#/account-summary) is more appropriate and easier to handle.
|
cACK |
|
This is a nice change but it destroys allowing requests to third parties based on the current url (e.g. can load moonpay when on buy page, etc.), because with the hash router, the Android webview does not register url changes anymore. The blocking of external requests can probably be circumvented by potential malware easily enough, so the benefit of doing this blocking while everything on some pages is questionable. We could simply remove the blocking and proceed with this PR. We could also abandon this PR, as I figured out how to fix routing on iOS without changing to the HashRouter. |
👍 closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the BrowserRouter is needlessly complicated, we don't need the browser to make a new "request" when we route to a different page. Getting this to work is especially difficult in iOS, where the file path to index.html is loaded in the webview, and routing to e.g.
/account-summary' fails because the absolute filepath/account-summary` does not exist and is outside the app folder sandbox.Using the hash router instead, where the app path is tracked behind the
#(e.g. index.html#/account-summary) is more appropriate and easier to handle.