Add CZK and PLN fiat currencies #2141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for Zloty (PLN), this is in the list of currencies supported by CoinGecko: - https://api.coingecko.com/api/v3/simple/supported_vs_currencies
Add support for Czech Crown (CZK), this is in the list of currencies supported by CoinGecko: - https://api.coingecko.com/api/v3/simple/supported_vs_currencies
Beerosagos
approved these changes
Jun 6, 2023
There was a problem hiding this comment.
Code LGTM, but I think there is some issue with geckoproxy historical data
INFO[0070] updateHistory(tbtc, PLN, 2023-03-08 16:51:20.356188551 +0100 CET m=-7772329.809681622, 2023-06-06 16:51:20.356188551 +0200 CEST m=+70.190318378): fetchGeckoMarketRange: bad response code 503 group=rates
INFO[0071] updateHistory(tltc, CZK, 2023-03-08 16:51:21.391894306 +0100 CET m=-7772328.773975866, 2023-06-06 16:51:21.391894306 +0200 CEST m=+71.226024134): fetchGeckoMarketRange: bad response code 503 group=rates
INFO[0071] updateHistory(tbtc, CZK, 2023-03-08 16:51:21.395049482 +0100 CET m=-7772328.770820722, 2023-06-06 16:51:21.395049482 +0200 CEST m=+71.229179278): fetchGeckoMarketRange: bad response code 503 group=rates
INFO[0072] updateHistory(tltc, PLN, 2023-03-08 16:51:22.232874972 +0100 CET m=-7772327.932995199, 2023-06-06 16:51:22.232874972 +0200 CEST m=+72.067004801): fetchGeckoMarketRange: bad response code 503 group=rates
INFO[0073] updateHistory(tltc, CZK, 2023-03-08 16:51:23.43963873 +0100 CET m=-7772326.726231448, 2023-06-06 16:51:23.43963873 +0200 CEST m=+73.273768552): fetchGeckoMarketRange: bad response code 503 group=rates
INFO[0074] updateHistory(tltc, PLN, 2023-03-08 16:51:24.291899797 +0100 CET m=-7772325.873970381, 2023-06-06 16:51:24.291899797 +0200 CEST m=+74.126029619): fetchGeckoMarketRange: bad response code 503 group=rates
INFO[0074] updateHistory(tbtc, PLN, 2023-03-08 16:51:24.400881814 +0100 CET m=-7772325.764988360, 2023-06-06 16:51:24.400881814 +0200 CEST m=+74.235011640): fetchGeckoMarketRange: bad response code 503 group=rates
INFO[0075] updateHistory(tltc, PLN, 2023-03-08 16:51:25.347998805 +0100 CET m=-7772324.817871364, 2023-06-06 16:51:25.347998805 +0200 CEST m=+75.182128636): fetchGeckoMarketRange: bad response code 503 group=rates
INFO[0075] updateHistory(tbtc, CZK, 2023-03-08 16:51:25.461292108 +0100 CET m=-7772324.704578068, 2023-06-06 16:51:25.461292108 +0200 CEST m=+75.295421932): fetchGeckoMarketRange: bad response code 503 group=rates
INFO[0076] updateHistory(tbtc, PLN, 2023-03-08 16:51:26.455997527 +0100 CET m=-7772323.709872633, 2023-06-06 16:51:26.455997527 +0200 CEST m=+76.290127367): fetchGeckoMarketRange: bad response code 503 group=rates
INFO[0076] updateHistory(tltc, CZK, 2023-03-08 16:51:26.496752777 +0100 CET m=-7772323.669117398, 2023-06-06 16:51:26.496752777 +0200 CEST m=+76.330882602): fetchGeckoMarketRange: bad response code 503 group=rates
INFO[0077] updateHistory(tltc, PLN, 2023-03-08 16:51:27.404787422 +0100 CET m=-7772322.761082759, 2023-06-06 16:51:27.404787422 +0200 CEST m=+77.238917241): fetchGeckoMarketRange: bad response code 503 group=rates
cc @benma
|
nice I think it's working now, don't get any errors anymore and chart is loading with PLN or CZK. merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.