Draft: Frontend update waiting view #2135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisconnect
force-pushed
the
frontend-revamp-waiting-view
branch
from
a7a6c7a
to
1b82a1a
Compare
Current waiting view has some weird boxed layout and redudant text i.e. 'Please connect your device' and 'For the BitBox02, please tap the device'. - changed to use View component - made title optional in View component (withAppLogo does not need to have a title) - added Subtitle component (which could be used in other places too) - changed welcome message (no double please) - cleanup styling (dont use bitbox01.module.css styles for waiting)
thisconnect
force-pushed
the
frontend-revamp-waiting-view
branch
from
1b82a1a
to
e4189cb
Compare
|
before:
|
|
new with this change:
|
|
with this change + dark mode
|
This change only effects View component that have both props: verticallyCentered and withBottomBar. This 2 props are used together in setup and waiting view.
thisconnect
force-pushed
the
frontend-revamp-waiting-view
branch
from
e4189cb
to
ed9271c
Compare
thisconnect
changed the title
|
I'll update the PR and try a version with the db logo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.