Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend vendor modules #2016

Closed
wants to merge 10 commits into from
Closed

Frontend vendor modules #2016

wants to merge 10 commits into from

Commits on Mar 16, 2023

  1. frontend: fork and vendor flag-icons 

    Added a reduced version of flag-icons in  frontends/web/node_vendor
with the following command:

npm i --save flag-icons@file:./node_vendor/flag-icons

Changes in flag-icons:
- removed devDeps and scripts from package.json
- removed unused less and sass files
    @thisconnect
    thisconnect committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    e2b9275 View commit details
    Browse the repository at this point in the history

  2. frontend: keep only 1:1 ch, va and np flags

    @thisconnect
    thisconnect committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    66999e4 View commit details
    Browse the repository at this point in the history

  3. frontend: add python script to update svg ids 

    Makes 'npm run ids' work again. This script adds the country code
to the svg's.

script taken with 1 modification (trycatch for missing imgs) from:
https://github.com/lipis/flag-icons/blob/29edfe0288970b77976024832f1f3cf0a8667357/flag-ids.py
    @thisconnect
    thisconnect committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    de906ec View commit details
    Browse the repository at this point in the history

  4. frontend: compress flags 

    As the flags are only shown in a dropdown they can be compressed
with less precission.

ran 'npm run svgo:all'
    @thisconnect
    thisconnect committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    d5bacfb View commit details
    Browse the repository at this point in the history

  5. frontend: replace do flag 

    This file had unusual small details.
    @thisconnect
    thisconnect committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    f285be0 View commit details
    Browse the repository at this point in the history

  6. frontend: remove unused npm scripts in vendored flag-icons

    @thisconnect
    thisconnect committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    e0ddaf2 View commit details
    Browse the repository at this point in the history

  7. frontend: flag-icons remove unused css 

    Removed minified CSS and unused 1x1 CSS classes with the follwing
regex:

\.fi-[a-z]{2}(-[a-z]{2,3})?\.fis \{\n  background-image: url\(\.\.\/flags\/1x1\/[a-z]{2}(-[a-z]{2,3})?\.svg\);\n\}\n
    @thisconnect
    thisconnect committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    6abb5f3 View commit details
    Browse the repository at this point in the history

  8. frontend: use 1x1 flags for ch, np and va 

    Some flags have a square format (1:1 ratio).
    @thisconnect
    thisconnect committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    ca193b8 View commit details
    Browse the repository at this point in the history

  9. frontend: remove white background of np flag 

    This is not visible in light mode but in dark mode the flag should
not have a white background.

Related:
- lipis/flag-icons#449
    @thisconnect
    thisconnect committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    bf8b577 View commit details
    Browse the repository at this point in the history

  10. frontend: update latest changes fron flag-icons 

    Applied unreleased changes, as they include fixes or reduce file
size i.e. do flag.
    @thisconnect
    thisconnect committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    86360fa View commit details
    Browse the repository at this point in the history