Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schnorr: final changes #161

Open
wants to merge 9 commits into
base: v0.2
Choose a base branch
from
Open

Schnorr: final changes #161

wants to merge 9 commits into from

Conversation

afk11
Copy link
Member

@afk11 afk11 commented Sep 5, 2019

Bringing the schnorr api up to date with the latest upstream changes.

Adds secp256k1_xonly_pubkey, a special type used by the schnorrsig module. Following upstream, this resource type and associated functions are now exposed in secp256k1.h (so the main library)

  • secp256k1_xonly_pubkey_create
  • secp256k1_xonly_pubkey_parse
  • secp256k1_xonly_pubkey_serialize
  • secp256k1_xonly_pubkey_from_pubkey
  • secp256k1_xonly_pubkey_tweak_verify
  • secp256k1_xonly_pubkey_tweak_add
  • secp256k1_xonly_privkey_tweak_add

@codecov
Copy link

codecov bot commented Sep 5, 2019

Codecov Report

Merging #161 into v0.2 will increase coverage by 0.29%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             v0.2     #161      +/-   ##
==========================================
+ Coverage   99.47%   99.76%   +0.29%     
==========================================
  Files           1        1              
  Lines         755      869     +114     
==========================================
+ Hits          751      867     +116     
+ Misses          4        2       -2
Impacted Files Coverage Δ
secp256k1/secp256k1.c 99.76% <100%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1fef29...6c8693a. Read the comment docs.

@afk11 afk11 force-pushed the schnorr2 branch 2 times, most recently from 5cb78a7 to a74f824 Compare September 5, 2019 20:41
@afk11
Copy link
Member Author

afk11 commented Oct 10, 2019

looks like the new secp256k1_xonly_* functions will be part of the main secp256k1 module. For now, switching to the schnorrsig commit for all test builds.

@afk11 afk11 force-pushed the schnorr2 branch 2 times, most recently from eac8337 to b3110de Compare October 10, 2019 16:39
afk11 added 2 commits October 10, 2019 17:47
And add relevant functions, which are now included in main library (tested)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant