Support match_phrase filter function in SQL and PPL #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: Yury Fridlyand <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
…ents. Signed-off-by: Yury Fridlyand <[email protected]>
Added a couple test for match_test in PPL. The tests are currently @ignore'd until more of the issue is complete. Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: Yury Fridlyand <[email protected]>
Signed-off-by: Yury Fridlyand <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: Yury Fridlyand <[email protected]>
Create a parametrized test for PPLSyntax parser. Signed-off-by: MaxKsyunz <[email protected]>
…x-min Add match_phrase and slop optional parameter to SQL parser
Signed-off-by: Yury Fridlyand <[email protected]>
Signed-off-by: Yury Fridlyand <[email protected]>
Signed-off-by: Yury Fridlyand <[email protected]>
Signed-off-by: Yury Fridlyand <[email protected]>
…for `MATCH` are also updated. Signed-off-by: Yury Fridlyand <[email protected]>
Signed-off-by: Yury Fridlyand <[email protected]>
Signed-off-by: Yury Fridlyand <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
1. Use PPL instead of SQL as samples. 2. Use data that doctest runs with. Signed-off-by: MaxKsyunz <[email protected]>
MaxKsyunz
requested review from
a team,
Yury-Fridlyand,
acarbonetto,
forestmvey and
raymond-lum
and removed request for
acarbonetto
acarbonetto
reviewed
May 6, 2022
core/src/main/java/org/opensearch/sql/expression/function/OpenSearchFunctions.java
Outdated
Show resolved
Hide resolved
acarbonetto
reviewed
May 6, 2022
core/src/main/java/org/opensearch/sql/expression/function/OpenSearchFunctions.java
Outdated
Show resolved
Hide resolved
acarbonetto
reviewed
May 6, 2022
...a/org/opensearch/sql/opensearch/storage/script/filter/lucene/relevance/MatchPhraseQuery.java
Show resolved
Hide resolved
acarbonetto
reviewed
May 6, 2022
...a/org/opensearch/sql/opensearch/storage/script/filter/lucene/relevance/MatchPhraseQuery.java
Outdated
Show resolved
Hide resolved
acarbonetto
reviewed
May 6, 2022
...a/org/opensearch/sql/opensearch/storage/script/filter/lucene/relevance/MatchPhraseQuery.java
Outdated
Show resolved
Hide resolved
acarbonetto
reviewed
May 6, 2022
...a/org/opensearch/sql/opensearch/storage/script/filter/lucene/relevance/MatchPhraseQuery.java
Show resolved
Hide resolved
core/src/test/java/org/opensearch/sql/expression/function/OpenSearchFunctionsTest.java
Show resolved
Hide resolved
integ-test/src/test/java/org/opensearch/sql/ppl/WhereCommandIT.java
Outdated
Show resolved
Hide resolved
added 6 commits
May 9, 2022 16:55
Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
Changed testMatchPhraseFunction and testMathPhraseWithSlop to use data source that exercises match_phrase. Signed-off-by: MaxKsyunz <[email protected]>
1. final variables for all constants. 2. Better name for getFunctionResolver -> getRelevanceFunctionResolver Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
acarbonetto
approved these changes
May 10, 2022
core/src/main/java/org/opensearch/sql/expression/function/OpenSearchFunctions.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/opensearch/sql/expression/function/OpenSearchFunctions.java
Outdated
Show resolved
Hide resolved
added 2 commits
May 9, 2022 19:01
Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
Yury-Fridlyand
approved these changes
May 10, 2022
forestmvey
approved these changes
May 10, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Resolves #185 except for backwards compatibility with the legacy SQL engine. This will be addressed in a separate commit.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.